Move processing of lhs_s_value method to Binding class #501
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yui-knk
reviewed
Jan 6, 2025
| @@ -30,6 +34,17 @@ def parameter_to_arg(symbol) | |||
| end | |||
| arg | |||
| end | |||
|
|
|||
| def token_to_args_s_values(token) | |||
| token.args.flat_map do |arg| | |||
There was a problem hiding this comment.
Note: Array#join expands array of array recursively then both #flat_map and #map works. However returning unnested array is simpler.
yui-knk
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR move processing of lhs_s_value method to Binding class.