Update CI with more os and jdk version. #568
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove tor set up from ci. use bash when run tests.
counter2015
commented
Mar 21, 2025
| jdk: [adopt@1.8] | ||
| scala: ['2.13', '3'] | ||
| jdk: | ||
| - temurin@8 |
There was a problem hiding this comment.
I'm not sure which release should we use to test. And do we need to add all LTS version JDK here? It may cause too much tests.
Comment on lines
+14
to
+17
| - ubuntu-latest | ||
| - windows-latest | ||
| - macos-14 | ||
| scala: |
There was a problem hiding this comment.
Like above, should we use specify version of OS to test, and other releases ?
Comment on lines
-28
to
-29
| - name: Setup Tor | ||
| uses: tor-actions/setup-tor@v1.0.0 |
There was a problem hiding this comment.
I'm not sure whether tor is used in CI.
|
@ruippeixotog could you have time to take a look at it ? What do you think about it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow configuration to enhance compatibility and improve the testing process across multiple operating systems and JDK versions. The key changes include expanding the matrix of environments, updating actions, and adding configuration steps for better platform support.
This PR is inspired by Cats-Effects CI file.
Updates to CI workflow configuration:
temurin@8,temurin@21) and operating systems (ubuntu-latest,windows-latest,macos-14).runs-onfield to use the matrix operating system and set a timeout of 60 minutes.actions/checkout@v4and adjusted the fetch depth to 0 for full branch checkout.olafurpg/setup-scala@v13withsbt/setup-sbt@v1.Enhancements to testing steps:
shell: bashto the test execution step to ensure compatibility with bash scripting.