Skip to content

Conversation

polarathene
Copy link
Contributor

reqwest is only used for a crate example basic HTTP call:

reqwest::get(&self.uri)

When cloning the project repo and running tests, it'd fail without OpenSSL devel package present on the system to build reqwest. I was going to replace that with rusttls but it seems HTTPS isn't required at all so opt-out of default features seems more prudent?

@polarathene polarathene requested a review from epage August 27, 2025 09:10
@polarathene polarathene self-assigned this Aug 27, 2025
@polarathene polarathene force-pushed the fix/build-dev-deps-without-openssl branch from 8650231 to c6f9fb2 Compare August 27, 2025 09:21
@coveralls
Copy link

coveralls commented Aug 27, 2025

Pull Request Test Coverage Report for Build 17283859396

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.259%

Totals Coverage Status
Change from base Build 17104337609: 0.0%
Covered Lines: 958
Relevant Lines: 1468

💛 - Coveralls

@epage
Copy link
Contributor

epage commented Aug 27, 2025

Fine with this change. CI needs addressing

@polarathene
Copy link
Contributor Author

CI needs addressing

Is there a preferred way to update Cargo.lock? Or just cargo update is ok for this project? Does that need to be run from Rust 1.75, or can it be done from a newer toolchain?

Some of the other Cargo.toml deps could probably be updated given the Rust 1.75 MSRV which would remove some duplicate crates, warp@0.3 for example could go to warp@0.4. It's also a dev-dependency but I'm not sure if you'd want it bundled in this PR or not? (if so do you want it all in a single commit?)

@epage
Copy link
Contributor

epage commented Aug 27, 2025

Run cargo check and commit amend your commit.

`reqwest` is only used for a basic HTTP call
@polarathene polarathene force-pushed the fix/build-dev-deps-without-openssl branch from c6f9fb2 to a19d1bd Compare August 28, 2025 02:19
@epage epage merged commit 00a5109 into rust-cli:main Aug 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants