feat: select! macro for no-std environments
#2903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `select!` macro works on only 64 bit architectures. Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
brodycj
reviewed
Jan 7, 2025
Comment on lines
70
to
73
| x ^= x >> 12; | ||
| x ^= x << 25; | ||
| x ^= x >> 27; | ||
| x = x.wrapping_mul(0x2545_f491_4f6c_dd1d); |
There was a problem hiding this comment.
This looks like repeated code, would be nice if we could refactor this somehow.
There was a problem hiding this comment.
Thank you for your review.
I prepared xorshift64star and xorshift32 functions.
Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
select!macro works only in the std environment.This PR fixes the implementation so that the
select!macro also works in no-std environments for 32- and 64-bit CPUs.The behavior in the std environment remains unchanged.