Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GMM covariances #322

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix GMM covariances #322

merged 1 commit into from
Nov 8, 2023

Conversation

relf
Copy link
Member

@relf relf commented Oct 20, 2023

Fixes #321

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39b3eee) 36.69% compared to head (4ce0db8) 36.73%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   36.69%   36.73%   +0.03%     
==========================================
  Files          94       94              
  Lines        6240     6240              
==========================================
+ Hits         2290     2292       +2     
+ Misses       3950     3948       -2     
Files Coverage Δ
...linfa-clustering/src/gaussian_mixture/algorithm.rs 47.17% <100.00%> (+0.27%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamiesandenr
Copy link

Thanks for this. I've tested it and it fixes the problem I was having.

@relf
Copy link
Member Author

relf commented Oct 24, 2023

@bytesnake, @quietlychris, could you merge this one? By the way, as @YuhanLiin is stepping away from linfa maintenance, I would like to let you know that I could help on this... like PR triage or even reviewing/merging this kind of PR.

Copy link
Member

@quietlychris quietlychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@quietlychris quietlychris merged commit 083fc9a into rust-ml:master Nov 8, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy in GMM covariance between sklearn and linfa
4 participants