Fix logger connection after opening serial protocol #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-fix-output-again
branch
from
5049580 to
faafb18
Compare
These are from section "Vendor-Defined Messaging Device Path" in the UEFI spec.
After opening the serial protocol in exclusive mode we have to reconnect it to the output console or we'll drop logs. After the recent upgrade to edk2 this code stopped working. Fix it by specifying the terminal type when calling `connect_controller`. This is needed because of edk2 commit cf6a0a52b07: "use utf8 for the serial console". The default terminal type (for OVMF) was changed from PC-ANSI to UTF-8. However, in TerminalDriverBindingStart, the terminal type will be reset to the default value of PC-ANSI if `remaining_device_path` is null. That in turn will prevent the code from finding the VT-UTF8 device. The terminal type on aarch64 is VT 100, so switch based on the target aarch.
We've had a few bugs where logging stopped working at some point during the tests. It's easy to miss that if you aren't paying careful attention to the log output, so add a test for it.
nicholasbishop
force-pushed
the
bishop-fix-output-again
branch
from
faafb18 to
18a01a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent PR to upgrade the edk2 prebuilts had a bug I didn't notice: the logging output gets cut off after the serial protocol is opened in exclusive mode.
This was caused by tianocore/edk2@cf6a0a5. Fix it by specifying the appropriate terminal type when calling
connect_controller.Since this bug has happened in various forms a couple times, also update the tests to catch it: check for a special log message right before exiting boot services, and fail the tests if that message is not received.
Checklist