Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto-release from crates.io to release #1068

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

nicholasbishop
Copy link
Member

Following up on #999 (comment), I finally got a separate repo created with the code to perform automatic releases. I created a simple bin crate (https://crates.io/crates/auto-release), so now we can drop all the release-related code from xtask.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
Copy link
Contributor

Hi! I'm still on vacation but I'm happy to review it after March 6th. However feel free to merge if you want

@nicholasbishop
Copy link
Member Author

I'll wait to merge, no rush. Enjoy your vacay :D

@nicholasbishop nicholasbishop force-pushed the bishop-simplify-release branch from 2b55d85 to 2022bbe Compare March 2, 2024 16:02
The Github Actions release workflow now uses
https://crates.io/crates/auto-release instead, so we don't need the xtask
implementation anymore.

This reverts (with some minor edits) these commits:
* d8bb47b "xtask: Add auto-release action"
* ad75b2f "xtask: Add util::run_cmd_capture_stdout"
* 910bfc3 "xtask: rename Package::as_str to Package::name and make pub"
@phip1611 phip1611 force-pushed the bishop-simplify-release branch from 2022bbe to 9e097c1 Compare March 13, 2024 16:25
Copy link
Contributor

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice :)

@nicholasbishop nicholasbishop added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 71bc7c1 Mar 13, 2024
15 checks passed
@nicholasbishop nicholasbishop deleted the bishop-simplify-release branch March 13, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants