add implementation of the tail command #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvoytek
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Nice! The implementation here looks good to me overall.
Also for reference here is the version of tail being added to Ubuntu questing - https://github.com/uutils/coreutils/blob/main/src/uu/tail/src/tail.rs
| for &byte in buffer[..chunk_size].iter().rev() { | ||
| result_bytes.push(byte); | ||
|
|
||
| if byte == b'\n' { |
There was a problem hiding this comment.
Do you want to handle the \r\n newline case here too? It's rare to find on Linux but it shows up from time to time
|
|
||
| result_bytes.reverse(); | ||
| let content = String::from_utf8_lossy(&result_bytes); | ||
| let mut lines: Vec<String> = content.lines().map(|s| s.to_string()).collect(); |
There was a problem hiding this comment.
This should be fine for most cases, but may differ from GNU coreutils/ UUtils coreutils as they copy over the resulting bytes in the lines directly. I'm fine with it either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3