Add support for RSA-PSS signature verification #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
approved these changes
Apr 3, 2024
| @@ -0,0 +1,7 @@ | |||
| # Generating Test Certificates | |||
There was a problem hiding this comment.
small nit: WDYT about replacing this .md documenting the commands to run with a .sh that runs them?
| OID_PKCS1_SHA384WITHRSA, OID_PKCS1_SHA512WITHRSA, OID_SHA1_WITH_RSA, OID_SIG_ECDSA_WITH_SHA256, | ||
| OID_SIG_ECDSA_WITH_SHA384, OID_SIG_ED25519, | ||
| }; | ||
| use std::convert::TryFrom; |
There was a problem hiding this comment.
I thought this might be superfluous but this crate is still using edition = "2018" and requires the import 👍 No action req'd, just leaving a note for the next reviewer.
Comment on lines
+100
to
+102
| let params = params.as_ref()?; | ||
| let params = RsaSsaPssParams::try_from(params).ok()?; | ||
| let hash_algo = params.hash_algorithm_oid(); |
There was a problem hiding this comment.
optional nit: I think some of the intermediate bindings might not add much value here:
Suggested change
| let params = params.as_ref()?; | |
| let params = RsaSsaPssParams::try_from(params).ok()?; | |
| let hash_algo = params.hash_algorithm_oid(); | |
| let hash_algo = RsaSsaPssParams::try_from(params.as_ref()?) | |
| .ok()? | |
| .hash_algorithm_oid(); |
There was a problem hiding this comment.
Functionally speaking, they are not required, but I think they makes debugging easier, and sometimes also easier fights with the compiler types engine :)
|
Applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.