Fix/rustsec 2025 0009 0.17 #193
Conversation
| @@ -436,7 +436,7 @@ impl<'a> TbsCertificate<'a> { | |||
| pub fn inhibit_anypolicy( | |||
| &self, | |||
| ) -> Result<Option<BasicExtension<&InhibitAnyPolicy>>, X509Error> { | |||
| self.get_extension_unique(&OID_X509_EXT_INHIBITANT_ANY_POLICY)? | |||
| self.get_extension_unique(&OID_X509_EXT_INHIBIT_ANY_POLICY)? | |||
There was a problem hiding this comment.
I'm confused what happened here, I fixed this instance, and the one in src/extensions/mod.rs already in 27dd7d2 no? Did that work get undone?
There was a problem hiding this comment.
Oh! I see now, this PR is targetting a x509-parser-0.17 feature branch 💡
In that case maybe next time it'd be better to cherry-pick the equivalent fixes from master where possible?
There was a problem hiding this comment.
Indeed, sorry I should have added it in the description.
I just created the x509-parser-0.17 branch to backport fixes (like this one). We can of course also cherry-pick any change that is interesting for this branch.
This is also in anticipation of some future breaking changes when this crate will have to be updated to the next asn1-rs releases (which have a lot of pending breaking changes in its API, and will require adjusting x509-parser). Of course the goal is to make the update as easy as possible.
CHANGELOG.md
Outdated
| ### Added/Changed/Fixed | ||
|
|
||
| Global: | ||
| - Upgrade `ring` to version >= 0.17.2. (#190 - RUSTSEC-2025-0009) |
There was a problem hiding this comment.
This should be .12:
| - Upgrade `ring` to version >= 0.17.2. (#190 - RUSTSEC-2025-0009) | |
| - Upgrade `ring` to version >= 0.17.12. (#190 - RUSTSEC-2025-0009) |
There was a problem hiding this comment.
oh, good catch thanks!
I force-pushed an updated version
chifflier
force-pushed
the
fix/rustsec-2025-0009-0.17
branch
from
9a5dd80 to
8099dc0
Compare
Update oid-registry to 0.8.1 (fix CI build)
Upgrade
ringto version >= 0.17.2. (#190 - RUSTSEC-2025-0009)