forked from project-chip/connectedhomeip
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink] Add Thread Optimization Configs #389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OPENTHREAD_CSMABACKOFF_OPTIMIZATION - IEEE802154_TLX_OPTIMIZATION and set COMMON_LIBC_MALLOC_ARENA_SIZE to 20kb if tl7218x_retention for power consumption optimization based on d6882ec. Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
- update zephyr revision to zephyr V3.7 - comment tl3218x_retention example due to ram limit. Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
134b0c3
to
61263b0
Compare
- increase COMMON_LIBC_MALLOC_ARENA_SIZE from 16kB to 20kB for tl7218x_retention to avoid overflow issue. - improve configs description. Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
- update OPENTHREAD_CSMABACKOFF_OPTIMIZATION description - update zephyr revision Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
@s07641069 @haiwentelink I believe it's okay to merge after your review. |
haiwentelink
approved these changes
Mar 10, 2025
s07641069
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and set COMMON_LIBC_MALLOC_ARENA_SIZE to 20kb if tl7218x_retention for power consumption optimization based on d6882ec.
The first commit (f5342e5) is only suitable for Zephyr V3.3 ( telink: tlx: apply ieee802154 optimization to zephyr v3.3 telink-semi/zephyr#488 - passed and merged to develop_v3.3 - Note that I did manually squash so the actual commit hash is 86fcdb43b64d6d10ad81172c61495c9e40de0403 )
The second commit (61263b0) does not work for tl7218x_retention as it cannot complete commissioning due to the limit of LIBC allocation size 16kB.
The third commit (dfabb0e) increases the limit to 20kB for tl7218x_retention while it maintains 16kB for tl7218kB so it is compatible for both Zephyr V3.3 and V3.7 (telink: tlx: apply tlx optimization to zephyr v3.7 telink-semi/zephyr#491 - passed and merged to develop)
The fourth commit (1cf5186) updates the description of the newly added configs and the Zephyr V3.7 revision after telink: tlx: apply tlx optimization to zephyr v3.7 telink-semi/zephyr#491 is merged.
Testing
Verified by CI