Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop customer new v3.3 #392

Draft
wants to merge 3 commits into
base: develop_customer_new_base
Choose a base branch
from
Draft

Develop customer new v3.3 #392

wants to merge 3 commits into from

Conversation

charlie-ai
Copy link
Collaborator

@charlie-ai charlie-ai commented Mar 13, 2025 •
edited by fengtai-telink
Loading

Testing

Verified by CI

@charlie-ai charlie-ai requested a review from s07641069 as a code owner March 13, 2025 08:43
@charlie-ai charlie-ai marked this pull request as draft March 13, 2025 08:44
@charlie-ai charlie-ai added the DNM label Mar 13, 2025
@s07641069
Copy link
Owner

Also I suggest you to include changes from project-chip#36691 which add Matter GitHub CI builds for both Zephyr versions or wait till this PR will be merged into master and after you can rebase your branch.
It will help you to check that all targets builds fine for both Zephyr versions.

@charlie-ai charlie-ai force-pushed the develop_customer_new_v3.3 branch 2 times, most recently from 2d17ad3 to ef324c2 Compare March 14, 2025 05:54
@fengtai-telink
Copy link
Collaborator

Also I suggest you to include changes from project-chip#36691 which add Matter GitHub CI builds for both Zephyr versions or wait till this PR will be merged into master and after you can rebase your branch. It will help you to check that all targets builds fine for both Zephyr versions.

Hi @s07641069 @haiwentelink ,
The current branch(develop_customer) is a separate PM development version provided to users based on Zephyr_3.3 . Currently, Zephyr_3.7 will not be integrated . And than it only supports tl3218x and b92 . Therefore, the CI only requires tl3218x and b92 series about PM .
@charlie-ai will further improve the CI targets of tl3218x and b92 . Thank ~

damien0x0023
damien0x0023 reviewed Mar 17, 2025
View reviewed changes
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
@@ -66,6 +66,10 @@ extern "C" void otSysProcessDrivers(otInstance * aInstance);
extern "C" void otAppCliInit(otInstance * aInstance);
#endif

#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION && CONFIG_IEEE802154_TLX_OPTIMIZATION

src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
@@ -379,6 +383,14 @@ bool GenericThreadStackManagerImpl_OpenThread<ImplClass>::_IsThreadAttached()
curRole = otThreadGetDeviceRole(mOTInst);
Impl()->UnlockThreadStack();

#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#if defined CONFIG_IEEE802154_TLX_OPTIMIZATION && CONFIG_IEEE802154_TLX_OPTIMIZATION

@charlie-ai charlie-ai force-pushed the develop_customer_new_v3.3 branch from ef324c2 to 92e407c Compare March 18, 2025 13:39
@haiwentelink
Copy link
Collaborator

haiwentelink commented Mar 19, 2025 •
edited
Loading

too many commit log ,need to adjust , shoud be 2 commit , one for nvs changes , others should be merged ,then we will review again .

@haiwentelink @charlie-ai
riscv:telink: update commit id and nvs config.
fa1e0dd 
- update commit id for zephyr.
- add NVS_RAM_OPTIMIZATION option.

Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
@haiwentelink @charlie-ai
[Telink] ieee802154 optimization for power consumption (#360)
848f08b 
* [Telink] ieee802154 optimization for power consumption

- reduce COMMON_LIBC_MALLOC_ARENA_SIZE to 13.5KB.
- add configs
  - OPENTHREAD_CSMABACKOFF_OPTIMIZATION,
  - ZEPHYR_NETBUFFER_OPTIMIZATION,
  - IEEE802154_TLX_OPTIMIZATION.
- reduce PACKETBUFFER_CAPACITY_MAX to 1024.
- remove shell in tl321x light switch app CI.
- update zephyr revision.
- set csma backoff in retention mode .

Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Signed-off-by: Lingzhi Chen <lingzhi.chen@telink-semi.com>
Signed-off-by: Liang Zhong <liang.zhong@telink-semi.com>
@charlie-ai charlie-ai force-pushed the develop_customer_new_v3.3 branch from 92e407c to 512ee2b Compare March 19, 2025 09:49
@charlie-ai charlie-ai force-pushed the develop_customer_new_v3.3 branch from 512ee2b to cbb6238 Compare March 27, 2025 06:56
s07641069
s07641069 requested changes Mar 27, 2025
View reviewed changes
Copy link
Owner

@s07641069 s07641069 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made mistake (space) in yaml file and as reason Telink CI not started
check list of Ci and fix
https://github.com/s07641069/connectedhomeip/actions/runs/14100660836

@charlie-ai
telink: test CI
6f5a7ae 
     - test CI

Signed-off-by: Lingzhi Chen <lingzhi.chen@telink-semi.com>
@charlie-ai charlie-ai force-pushed the develop_customer_new_v3.3 branch from cbb6238 to 6f5a7ae Compare March 28, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damien0x0023 damien0x0023 damien0x0023 left review comments

@s07641069 s07641069 s07641069 requested changes

@andy-liu-telink andy-liu-telink Awaiting requested review from andy-liu-telink

@pulin1103 pulin1103 Awaiting requested review from pulin1103

@haiwentelink haiwentelink Awaiting requested review from haiwentelink

Assignees
No one assigned
Labels
config DNM github platform telink workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@charlie-ai @s07641069 @fengtai-telink @haiwentelink @damien0x0023