Skip to content

Follow the PR #39990, revert "src/doc/zh/**/conf.py: Fix handling of tags" #40025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025

Conversation

fisheryv
Copy link
Contributor

Follow the PR #39990, remove ability to conditionalize parts of the documentation from Chinese docs.

I have reverted src/doc/zh/**/conf.py as what @tobiasdiez did in commit fc6a150. @vbraun

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#39990 : Remove ability to conditionalize parts of the documentation

Copy link

Documentation preview for this PR (built with commit 16a9da0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request May 1, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags"
    
Follow the PR sagemath#39990, remove ability to conditionalize parts of the
documentation  from Chinese docs.

I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in
commit fc6a150. @vbraun

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#39990 : Remove ability to conditionalize parts of the documentation
    
URL: sagemath#40025
Reported by: Fisher
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags"
    
Follow the PR sagemath#39990, remove ability to conditionalize parts of the
documentation  from Chinese docs.

I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in
commit fc6a150. @vbraun

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#39990 : Remove ability to conditionalize parts of the documentation
    
URL: sagemath#40025
Reported by: Fisher
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags"
    
Follow the PR sagemath#39990, remove ability to conditionalize parts of the
documentation  from Chinese docs.

I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in
commit fc6a150. @vbraun

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#39990 : Remove ability to conditionalize parts of the documentation
    
URL: sagemath#40025
Reported by: Fisher
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags"
    
Follow the PR sagemath#39990, remove ability to conditionalize parts of the
documentation  from Chinese docs.

I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in
commit fc6a150. @vbraun

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#39990 : Remove ability to conditionalize parts of the documentation
    
URL: sagemath#40025
Reported by: Fisher
Reviewer(s): Tobias Diez
@vbraun vbraun merged commit 65116a5 into sagemath:develop May 11, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants