-
-
Notifications
You must be signed in to change notification settings - Fork 610
Follow the PR #39990, revert "src/doc/zh/**/conf.py: Fix handling of tags" #40025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the documentation from Chinese docs.
5 tasks
Documentation preview for this PR (built with commit 16a9da0; changes) is ready! 🎉 |
tobiasdiez
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 1, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags" Follow the PR sagemath#39990, remove ability to conditionalize parts of the documentation from Chinese docs. I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in commit fc6a150. @vbraun ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39990 : Remove ability to conditionalize parts of the documentation URL: sagemath#40025 Reported by: Fisher Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 4, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags" Follow the PR sagemath#39990, remove ability to conditionalize parts of the documentation from Chinese docs. I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in commit fc6a150. @vbraun ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39990 : Remove ability to conditionalize parts of the documentation URL: sagemath#40025 Reported by: Fisher Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 5, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags" Follow the PR sagemath#39990, remove ability to conditionalize parts of the documentation from Chinese docs. I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in commit fc6a150. @vbraun ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39990 : Remove ability to conditionalize parts of the documentation URL: sagemath#40025 Reported by: Fisher Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 6, 2025
sagemathgh-40025: Follow the PR sagemath#39990, revert "src/doc/zh/**/conf.py: Fix handling of tags" Follow the PR sagemath#39990, remove ability to conditionalize parts of the documentation from Chinese docs. I have reverted ` src/doc/zh/**/conf.py` as what @tobiasdiez did in commit fc6a150. @vbraun ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39990 : Remove ability to conditionalize parts of the documentation URL: sagemath#40025 Reported by: Fisher Reviewer(s): Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the PR #39990, remove ability to conditionalize parts of the documentation from Chinese docs.
I have reverted
src/doc/zh/**/conf.py
as what @tobiasdiez did in commit fc6a150. @vbraun📝 Checklist
⌛ Dependencies
#39990 : Remove ability to conditionalize parts of the documentation