Avoid excessive interpolation in pari gphelp script. #40028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a blocker if one wants to build sage and have for example an @ sign in SAGE_LOCAL. While admittedly not common, it should not cause failure.
|
Documentation preview for this PR (built with commit 34e4e85; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sage does not build if
SAGE_LOCALcontains an@sign. While admittedly not common, it should not cause failure.The offender is pari. pari itself compiles fine, but cypari calls
gphelp -raw Catalanto see if everything works alright, and this fails.The reason is that
gphelpis malformed, and can't find its data directory. Primarily, this is based on the following erroneous perl construct:which is found near the top of the
doc/gphelp.infile.This goes obviously amiss if
@datadir@contains an@sign, because of the double quotes. AFAIK, the best perl-ish way to be robust to semi-crap that can be found in paths is to use a quoted here-doc, which is what this patch does.Also reported upstream https://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=2621