Precision issue in the normalization of a Tate series #40046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 9713051; changes) is ready! 🎉 |
vilanele
approved these changes
May 5, 2025
TristanVaccon
approved these changes
May 6, 2025
|
All tests seem to pass (the error, which is reported, is a priori unrelated to this PR). |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 6, 2025
sagemathgh-40046: Precision issue in the normalization of a Tate series This PR fixes the following bug: ``` sage: S.<x,y> = TateAlgebra(Qp(5), log_radii=(1,0)) sage: f = 5*x sage: f.valuation() 0 sage: f.add_bigoh(1) O(5 * <x/5, y>) ``` The correct answer is `(5 + O(5^2))*x + O(5 * <x/5, y>)` given that the first summand is not absorbed by the `O(.)`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40046 Reported by: Xavier Caruso Reviewer(s): TristanVaccon, Vilanele
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bug:
The correct answer is
(5 + O(5^2))*x + O(5 * <x/5, y>)given that the first summand is not absorbed by theO(.).📝 Checklist