Bugfix: failed exception treated as successful should not trigger exception in pool

src/HttpSender.php

@@ -129,9 +129,10 @@ function (HttpRequestException|TransferException $exception) use ($pendingReques
 
                     $response = $this->createResponse($exception->response->toPsrResponse(), $pendingRequest, $psrRequest, $exception);
 
-                    // Throw the exception our way
+                    // Throw the exception our way if there is an exception.
+                    // Otherwise we'll return the response.
 
-                    throw $response->toException();
+                    return ($exception = $response->toException()) ? throw $exception : $response;
                 }
             );
     }

tests/Feature/PoolTest.php

@@ -11,6 +11,7 @@
 use Saloon\HttpSender\Tests\Fixtures\Requests\UserRequest;
 use Saloon\HttpSender\Tests\Fixtures\Connectors\HttpSenderConnector;
 use Saloon\HttpSender\Tests\Fixtures\Connectors\InvalidConnectionConnector;
+use Saloon\HttpSender\Tests\Fixtures\Requests\ErrorRequestThatShouldBeTreatedAsSuccessful;
 
 test('you can create a pool on a connector', function () {
     $connector = new HttpSenderConnector;
@@ -76,3 +77,26 @@
 
     expect($count)->toEqual(5);
 });
+
+test('if a pool has a failed response that should be treated as a successful response', function () {
+    $count = 0;
+
+    $pool = (new HttpSenderConnector)->pool([
+        new ErrorRequestThatShouldBeTreatedAsSuccessful,
+    ]);
+
+    $pool->withResponseHandler(function (Response $response) use (&$count) {
+        expect($response)->toBeInstanceOf(Response::class);
+        expect($response->status())->toBe(404);
+
+        $count++;
+    });
+
+    $promise = $pool->send();
+
+    expect($promise)->toBeInstanceOf(PromiseInterface::class);
+
+    $promise->wait();
+
+    expect($count)->toEqual(1);
+});

tests/Fixtures/Requests/ErrorRequestThatShouldBeTreatedAsSuccessful.php

@@ -0,0 +1,30 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Saloon\HttpSender\Tests\Fixtures\Requests;
+
+use Saloon\Enums\Method;
+use Saloon\Http\Request;
+use Saloon\Http\Response;
+
+class ErrorRequestThatShouldBeTreatedAsSuccessful extends Request
+{
+    /**
+     * HTTP Method
+     */
+    protected Method $method = Method::GET;
+
+    /**
+     * Resolve the endpoint
+     */
+    public function resolveEndpoint(): string
+    {
+        return '/not-found-error';
+    }
+
+    public function hasRequestFailed(Response $response): ?bool
+    {
+        return $response->status() !== 404;
+    }
+}