-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update
derive field overwrite support
#747
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #747 will not alter performanceComparing Summary
|
e808e8b
to
1dc4815
Compare
Actually, @MichaReiser I believe this could be a viable alternative for the |
Update
derive field overwrite supportUpdate
derive field overwrite support
b86d75b
to
f682959
Compare
Yeah, it does reduce the urgency for having |
Well, I don't see better ways to avoid this. We obivously can't add every crate out there as a dependency to salsa just to add the |
f682959
to
c4cf0d9
Compare
Either way I believe this to be a nice addition to the derive. Improved the diagnostics a bit so this is ready now |
I agree with this. It definitely raises the bar for which Crate Salsa should provide |
0aebe9f
to
398e134
Compare
I believe this should allow reducing the need for coherence dependencies like
salsa/Cargo.toml
Lines 29 to 30 in ceb9b08