Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination collection (issue #6684) #6985

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

zizneroz
Copy link
Contributor

Fixes

Fixes #6684; refs #6684

Summary

Resolve issue #6684: Adjust collection page layout by changing the CSS display property to use flexbox for proper alignment of elements.


Guidance for testing

  • Navigate to the collections page in the application.
  • Verify that the layout of the collections now aligns correctly.
  • Test on various screen sizes and browsers to ensure the layout is responsive and consistent.
  • Check for any regressions in other areas where the same styles might be applied.

Type of change (for release notes)

notes-bugfix


Detailed Description

This pull request resolves #6684, where the collections page layout was misaligned due to the use of display: block. By updating the CSS property to display: flex in app/assets/stylesheets/hyrax/_collections.scss (line 687), the layout now uses flexbox for proper alignment and spacing.

Code changed:

// Before:
display: block;

// After:
display: flex;


@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Dec 11, 2024

Test Results

    1 files   -     12      1 suites   - 12   0s ⏱️ - 2h 51m 0s
1 741 tests  -  5 092  1 741 ✅  -  4 793  0 💤  - 299  0 ❌ ±0 
1 741 runs   - 16 359  1 741 ✅  - 15 882  0 💤  - 477  0 ❌ ±0 

Results for commit 88ee995. ± Comparison against base commit 4baa51f.

♻️ This comment has been updated with latest results.

@zizneroz zizneroz merged commit b6dcb8a into samvera:main Jan 8, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination on collection view not displayed correctly
2 participants