align headers, clean up imports & fix typo #17
Conversation
| @@ -6,8 +6,8 @@ | |||
| URL_SERVICE_INCIDENT = 'https://launchpad.support.sap.com/services/odata/incidentws' | |||
| URL_SERVICE_USER_ADMIN = 'https://launchpad.support.sap.com/services/odata/useradminsrv' | |||
| URL_SOFTWARE_DOWNLOAD = 'https://softwaredownloads.sap.com' | |||
| # Maintainance Planner | |||
| URL_MAINTAINANCE_PLANNER = 'https://maintenanceplanner.cfapps.eu10.hana.ondemand.com' | |||
| # Maintenance Planner | |||
There was a problem hiding this comment.
fixed typo
|
|
||
| from . import constants as C | ||
| from .sap_api_common import _request, https_session | ||
| from .sap_id_sso import _get_sso_endpoint_meta, sap_sso_login | ||
| from .sap_id_sso import _get_sso_endpoint_meta |
There was a problem hiding this comment.
there was no reference to sap_sso_login in this file, causing linters to complain - so I moved the imports into the files that actually reference the sap_sso_login function.
| from . import constants as C | ||
| from .sap_api_common import _request | ||
| from .sap_id_sso import sap_sso_login |
There was a problem hiding this comment.
| @@ -12,7 +9,7 @@ | |||
|
|
|||
| from . import constants as C | |||
| from .sap_api_common import _request, https_session | |||
| from .sap_id_sso import _get_sso_endpoint_meta, sap_sso_login | |||
| from .sap_id_sso import _get_sso_endpoint_meta | |||
There was a problem hiding this comment.
| @@ -5,7 +5,6 @@ | |||
|
|
|||
| from . import constants as C | |||
| from .sap_api_common import _request | |||
| from .sap_id_sso import sap_sso_login | |||
There was a problem hiding this comment.
| @@ -69,6 +69,7 @@ | |||
| from ..module_utils.sap_launchpad_maintenance_planner_runner import * | |||
| from ..module_utils.sap_launchpad_software_center_download_runner import \ | |||
| is_download_link_available | |||
| from ..module_utils.sap_id_sso import sap_sso_login | |||
There was a problem hiding this comment.
| @@ -69,6 +69,7 @@ | |||
|
|
|||
| # Import runner | |||
| from ..module_utils.sap_launchpad_maintenance_planner_runner import * | |||
| from ..module_utils.sap_id_sso import sap_sso_login | |||
There was a problem hiding this comment.
| @@ -88,6 +88,7 @@ | |||
|
|
|||
| # Import runner | |||
| from ..module_utils.sap_launchpad_software_center_download_runner import * | |||
| from ..module_utils.sap_id_sso import sap_sso_login | |||
There was a problem hiding this comment.
|
@rainerleber thanks! Can you merge the PR? I'm afraid I don't have the rights:
|
|
PR #16 merged to |
|
@sean-freeman thanks! |
Hi folks
As discussed with @rainerleber in #16 (comment), the file headers are in need of some alignment ;)
This PR does the following:
Along the way I fixed a typo and arranged some imports - see inline comments.