patvar: adjust caret in error message #23115
Merged
+13
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
approved these changes
May 7, 2025
| | Type ascriptions after patterns other than: | ||
| | * variable pattern, e.g. `case x: String =>` | ||
| | * number literal pattern, e.g. `case 10.5: Double =>` | ||
| | are no longer supported. Remove the type ascription or move it to a separate variable pattern. |
There was a problem hiding this comment.
Ah, this line is commented out in Scala 2 because parser doesn't recover.
| | Type ascriptions after patterns other than: | ||
| | * variable pattern, e.g. `case x: String =>` | ||
| | * number literal pattern, e.g. `case 10.5: Double =>` | ||
| | are no longer supported. Remove the type ascription or move it to a separate variable pattern. |
There was a problem hiding this comment.
Sorry I didn't notice it before; I was distracted by the long message and the fact that Scala 2 doesn't support it.
One could misquote the saying about seeing the caret in one's brother's eye.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported scala/scala#11056