Skip to content

Add config to set buckets default SSE config #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development/7.70
Choose a base branch
from
Open

Add config to set buckets default SSE config #5625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/Config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,22 @@ class Config extends EventEmitter {
'bad config: maxScannedLifecycleListingEntries must be greater than 2');
this.maxScannedLifecycleListingEntries = config.maxScannedLifecycleListingEntries;
}

this.defaultBucketSseConfig = {};
if (config.defaultBucketSseConfig) {
const algorithm = config.defaultBucketSseConfig.algorithm;
if (algorithm !== undefined) {
assert(algorithm === 'AES256',
'bad config: defaultBucketSseConfig.algorithm must be AES256');
this.defaultBucketSseConfig.algorithm = algorithm;
}
const mandatory = config.defaultBucketSseConfig.mandatory;
if (mandatory !== undefined) {
assert(typeof mandatory === 'boolean',
'bad config: defaultBucketSseConfig.mandatory must be a boolean');
this.defaultBucketSseConfig.mandatory = mandatory;
}
}
}

_configureBackends() {
Expand Down
3 changes: 3 additions & 0 deletions lib/api/apiUtils/bucket/bucketCreation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const { parseBucketEncryptionHeaders } = require('./bucketEncryption');
const metadata = require('../../../metadata/wrapper');
const kms = require('../../../kms/wrapper');
const isLegacyAWSBehavior = require('../../../utilities/legacyAWSBehavior');
const { config } = require('../../../Config');

const usersBucket = constants.usersBucket;
const oldUsersBucket = constants.oldUsersBucket;
Expand Down Expand Up @@ -230,6 +231,8 @@ function createBucket(authInfo, bucketName, headers,
const newBucketMD = results.prepareNewBucketMD;
if (existingBucketMD === 'NoBucketYet') {
const sseConfig = parseBucketEncryptionHeaders(headers);
sseConfig.algorithm = sseConfig.algorithm ?? config.defaultBucketSseConfig.algorithm ?? null;
sseConfig.mandatory = sseConfig.mandatory ?? config.defaultBucketSseConfig.mandatory ?? false;
return bucketLevelServerSideEncryption(
bucketName, sseConfig, log,
(err, sseInfo) => {
Expand Down