CLDSRV-717: Test S3C setup like in Integration #5914

BourgoisMickael · 2025-08-25T13:14:57Z

To catch errors faster than waiting to run Integration

Note: the commit 788a356 will be reverted once all tests are fixed for S3C

bert-e · 2025-08-25T13:15:00Z

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-08-25T13:15:06Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

codecov · 2025-08-25T13:15:48Z

❌ 104 Tests Failed:

Tests completed	Failed	Passed	Skipped
20559	104	20455	0

View the top 3 failed test(s) by shortest run time

should return the next truncate list of current versions before a defined date::listLifecycleCurrents with bucket versioning Disabled should return the next truncate list of current versions before a defined date

Stack Traces | 0.001s run time

ifError got unwanted exception: The AWS access key Id you provided does not exist in our records.

should return the non current versions before a defined date::listLifecycleNonCurrents should return the non current versions before a defined date

Stack Traces | 0.001s run time

ifError got unwanted exception: The AWS access key Id you provided does not exist in our records.

should truncate list of current versions before a defined date::listLifecycleCurrents with bucket versioning Disabled should truncate list of current versions before a defined date

Stack Traces | 0.001s run time

ifError got unwanted exception: The AWS access key Id you provided does not exist in our records.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

Copilot

Pull Request Overview

This PR adds S3C (Scality Cloud) functional testing configuration to mirror the Integration environment setup. It introduces comprehensive test infrastructure for S3C compatibility testing by creating location configurations, credentials, and CI workflow integration.

Key changes include:

S3C location configuration file with multiple data center definitions
S3C credentials setup for test accounts (default, lisa, replication)
New GitHub Actions workflow job for S3C functional tests with complete test suite execution

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/locationConfig/locationConfigS3C.json	Defines S3C location configurations for multiple data centers and storage classes
tests/functional/aws-node-sdk/lib/json/s3c_credentials.json	Provides test credentials for S3C accounts (default, lisa, replication)
.github/workflows/tests.yaml	Adds new s3c-ft-tests job with comprehensive functional test execution
.github/docker/setup-s3c.sh	Script to configure S3C environment and accounts matching Integration setup
.github/docker/md-config-v0.json	Metadata configuration for S3C testing environment
.github/docker/docker-compose.sse.yaml	Extends Docker Compose with metadata-standalone service and S3C location config
.github/docker/config.s3c.json	Main S3C configuration file with endpoints, services, and feature settings
.github/actions/setup-ci/action.yaml	Adds S3C-specific hostname mapping for website endpoints

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

.github/docker/setup-s3c.sh

To be reverted once all tests pass

anurag4DSB

Do we want to deploy vault as well if we want to do it like integration?

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

tcarmet

Pretty awesome call into executing this testsuite here 👌

I have to state though that the setup is starting to look a bit similar to a workbench setup. I don't think workbench have all the necessary config capabilities/code to make it equal, but I think it's worth you having a quick look at it, and share some thoughts onto which direction we should go to eventually add those capabilities in.

tcarmet · 2025-08-25T16:23:49Z

.github/docker/setup-s3c.sh

+echo "Copying s3c credentials to mem credentials"
+cp \
+    $SCRIPT_DIR/../../tests/functional/aws-node-sdk/lib/json/s3c_credentials.json \
+    $SCRIPT_DIR/../../tests/functional/aws-node-sdk/lib/json/mem_credentials.json


Is this file supposed to be added in the .gitignore?

No this is executed in the CI

tcarmet · 2025-08-25T16:24:26Z

.github/docker/setup-s3c.sh

+    --canonicalid 79a59df900b949e55d96a1e698fbacedfd6e09d98eacf8f8d5218e7cd47ef2be
+$VAULTCLIENT --config $CONFIG generate-account-access-key \
+    --name Bart \
+    --accesskey ACC1AK00000000000000 \


Since we are specifying those credentials in s3c_credentials.json should we read from it?

Not necessarily, I've hardcoded here so we can easily rerun manually and quickly troubleshoot without having to look for creds. Same for Integration, it will be hardcoded

BourgoisMickael · 2025-08-25T16:42:25Z

Do we want to deploy vault as well if we want to do it like integration?

@anurag4DSB Yes vault is deployed as well (the latest version with node 22)

BourgoisMickael · 2025-08-25T16:48:19Z

/create_integration_branches

bert-e · 2025-08-25T16:48:30Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-717-s3c-tests-setup into
development/9.0
w/9.1/improvement/CLDSRV-717-s3c-tests-setup will be merged into development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-08-25T16:48:31Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

BourgoisMickael · 2025-08-26T13:04:27Z

/approve

bert-e · 2025-08-26T13:04:39Z

Build failed

The build for commit did not succeed in branch w/9.1/improvement/CLDSRV-717-s3c-tests-setup

The following options are set: approve, create_integration_branches

bert-e · 2025-08-26T15:28:36Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.0
✔️ development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2025-08-26T15:57:05Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.0
✔️ development/9.1

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8

Please check the status of the associated issue CLDSRV-717.

Goodbye bourgoismickael.

BourgoisMickael requested a review from Copilot August 25, 2025 13:15

Copilot AI reviewed Aug 25, 2025

View reviewed changes

.github/docker/setup-s3c.sh Outdated Show resolved Hide resolved

BourgoisMickael added 2 commits August 25, 2025 15:32

CLDSRV-717: Test S3C setup like in Integration

5b8ad15

CLDSRV-717: S3C tests ignore errors for now

788a356

To be reverted once all tests pass

BourgoisMickael force-pushed the improvement/CLDSRV-717-s3c-tests-setup branch from 59bcce7 to 788a356 Compare August 25, 2025 13:32

anurag4DSB approved these changes Aug 25, 2025

View reviewed changes

Copilot AI reviewed Aug 25, 2025

View reviewed changes

tcarmet approved these changes Aug 25, 2025

View reviewed changes

bert-e merged commit 6c0f19d into development/9.0 Aug 26, 2025
42 of 49 checks passed

bert-e deleted the improvement/CLDSRV-717-s3c-tests-setup branch August 26, 2025 15:57

CLDSRV-717: Test S3C setup like in Integration #5914

CLDSRV-717: Test S3C setup like in Integration #5914

Uh oh!

Conversation

BourgoisMickael commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Aug 25, 2025

Hello bourgoismickael,

Uh oh!

bert-e commented Aug 25, 2025

Request integration branches

Uh oh!

codecov bot commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 104 Tests Failed:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

anurag4DSB left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

tcarmet left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tcarmet Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

tcarmet Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael commented Aug 25, 2025

Uh oh!

BourgoisMickael commented Aug 25, 2025

Uh oh!

bert-e commented Aug 25, 2025

Integration data created

Uh oh!

bert-e commented Aug 25, 2025

Waiting for approval

Uh oh!

BourgoisMickael commented Aug 26, 2025

Uh oh!

bert-e commented Aug 26, 2025

Build failed

Uh oh!

bert-e commented Aug 26, 2025

In the queue

Uh oh!

bert-e commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

BourgoisMickael commented Aug 25, 2025 •

edited

Loading

codecov bot commented Aug 25, 2025 •

edited

Loading

tcarmet left a comment •

edited

Loading