scx_layered: associate each layer with a cpumask #1972
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htejun
approved these changes
May 24, 2025
| @@ -351,6 +351,7 @@ struct layer { | |||
| char name[MAX_LAYER_NAME]; | |||
| bool is_protected; | |||
| bool periodically_refresh; | |||
| u8 cpuset[MAX_CPUS_U8]; | |||
There was a problem hiding this comment.
While it's following the existing usage, it'd probably be better to switch to u64 for bpf masks. All registers are 64bits anyway, so using u8 would just add unnecessasry masking operations.
|
Misc thing for later, this should probably error if the last layer has a cpuset on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associate each layer in the scheduler with the cpuset of the tasks running in the layer. This will be used in the future to improve support for containers that have associated cpusets.