Skip to content

Change how guide assignment model saves params from uns to var #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 7, 2025

Conversation

stefanpeidli
Copy link
Collaborator

@stefanpeidli stefanpeidli commented May 2, 2025

PR Checklist

Description of changes

Instead of saving the guide assignment mixture model parameters to adata.uns, we now save to adata.var.

@github-actions github-actions bot added the bug Something isn't working label May 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (3e7f1ce) to head (919793f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   72.19%   72.25%   +0.05%     
==========================================
  Files          47       47              
  Lines        5445     5449       +4     
==========================================
+ Hits         3931     3937       +6     
+ Misses       1514     1512       -2     
Files with missing lines Coverage Δ
pertpy/preprocessing/_guide_rna.py 79.13% <100.00%> (+2.55%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanpeidli stefanpeidli requested a review from Zethson May 7, 2025 12:26
@stefanpeidli stefanpeidli marked this pull request as ready for review May 7, 2025 12:28
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Zethson Zethson merged commit 7d7a280 into main May 7, 2025
7 checks passed
@stefanpeidli stefanpeidli deleted the fix/guide_assignment_uns branch May 7, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixture Model stores arrays in .uns which don't allow the AnnData object to be written
3 participants