-
Notifications
You must be signed in to change notification settings - Fork 16
nan handling for continuous and categorical coloring #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
nan handling for continuous and categorical coloring #427
Conversation
…ints/shapes separately before colored
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 84.92% 85.32% +0.40%
==========================================
Files 8 8
Lines 1784 1820 +36
==========================================
+ Hits 1515 1553 +38
+ Misses 269 267 -2
🚀 New features to boost your workflow:
|
if np.any(color_source_vector.isna()): | ||
cell_id[color_source_vector.isna()] = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In seg, the value 0 depicts the background, so this would lead to the bg being mapped to the NaN color
The actual label(s) with na in the color_source_vector don't have their id in cell_id anymore, so they're mapped to nothing! => would look like background
Fix coloring of shapes, labels and points when there are nan values in the vectors to color by