feat(redirect): Coverting policy into tower-http policy.
#2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linyihai
commented
Mar 28, 2025
| @@ -405,7 +405,7 @@ async fn test_redirect_limit() { | |||
| let res = client.get(&url).send().await.unwrap_err(); | |||
| assert_eq!( | |||
| res.url().unwrap().as_str(), | |||
| format!("http://{}/redirect/2", server.addr()).as_str() | |||
| format!("http://{}/redirect/3", server.addr()).as_str() | |||
linyihai
changed the title
tower-http policy instead.tower-http policy.
linyihai
force-pushed
the
redirect-refactor
branch
from
b400be6 to
4cf8a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this want to do
Working on #2576
Inspired by #2613 (comment)
This PR converts the
rewqest::redirect::Policyastower_http::follow_redirect::policy::Policy.Why the policy conversion needs happen in the
ClientBuild::buildfunction?Because the
Policiesfromtower-httpneeds to bemutand will change their inner state during redirect. See the Limited code.How to test
The first commit add the
LimitandCustompolicy test. The second commit make the implementation and updated the test.Others
Needs to do
Policy::checkmethod and test ?tower-http