Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Add overflowX and whiteSpace props #603

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Table: Add overflowX and whiteSpace props #603

merged 2 commits into from
Jan 22, 2024

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jan 22, 2024

Default overflowX="scroll" overflowX="scroll" whiteSpace="nowrap"
Screen Shot 2024-01-23 at 08 28 04 Screen Shot 2024-01-23 at 08 28 12 Screen Shot 2024-01-23 at 08 28 16

Motivation: https://developer.seek.com/schema can look a bit shoddy on mobile:

Screen Shot 2024-01-23 at 08 30 25

@72636c 72636c requested a review from a team as a code owner January 22, 2024 21:31
@AaronMoat
Copy link
Contributor

This is changesets now - not sure why the bot isn't working, actually

@72636c
Copy link
Member Author

72636c commented Jan 22, 2024

Oh looks like we didn't add the app to this repo ✅

@72636c 72636c merged commit b535d05 into master Jan 22, 2024
4 checks passed
@72636c 72636c deleted the table-overflow branch January 22, 2024 21:57
@72636c 72636c changed the title feat(Table): Add overflowX and whiteSpace props Table: Add overflowX and whiteSpace props Jan 22, 2024
@seek-oss-ci seek-oss-ci mentioned this pull request Jan 22, 2024
Merged
@72636c 72636c mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronMoat AaronMoat AaronMoat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@72636c @AaronMoat