Skip to content

Commit

Permalink
self-review tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
dssei committed Jan 6, 2025
1 parent 1c477e0 commit bb358a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion precompiles/confidentialtransfers/ct.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func (p PrecompileExecutor) getValidAddressesFromString(ctx sdk.Context, addr st
return p.getAssociatedAddressesBySeiAddress(ctx, addr)
}

// getValidSeiAddressFromString returns the associated Sei address given an EVM or Sei address
// getValidSeiAddressFromString returns the validated Sei address given an (EVM or native Sei) address string
// This method is for the case when we need to get the Sei address, but do not require it to be associated with an EVM
// address (unless EVM address is provided as an argument)
func (p PrecompileExecutor) getValidSeiAddressFromString(ctx sdk.Context, addr string) (sdk.AccAddress, error) {
Expand Down
6 changes: 3 additions & 3 deletions precompiles/confidentialtransfers/ct_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ func TestPrecompileTransfer_Execute(t *testing.T) {
wantErrMsg string
}{
{
name: "precompile should return true of input is valid",
name: "precompile should return true if input is valid",
wantRet: expectedTrueResponse,
wantRemainingGas: 0xec0b6,
wantErr: false,
},
{
name: "precompile should return true of input is valid and sender is Sei address",
name: "precompile should return true if input is valid and sender is Sei address",
args: args{setUp: func(in inputs) inputs {
in.senderAddr = senderAddr.String()
return in
Expand All @@ -76,7 +76,7 @@ func TestPrecompileTransfer_Execute(t *testing.T) {
wantErr: false,
},
{
name: "precompile should return true of input is valid and receiver is Sei address",
name: "precompile should return true if input is valid and receiver is Sei address",
args: args{setUp: func(in inputs) inputs {
in.receiverAddr = receiverAddr.String()
return in
Expand Down

0 comments on commit bb358a9

Please sign in to comment.