Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dynamic gas for address precompile #1962

Merged
merged 1 commit into from
Nov 25, 2024
Merged

use dynamic gas for address precompile #1962

merged 1 commit into from
Nov 25, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Nov 25, 2024

Describe your changes and provide context

The addr precompile may use iterators for funds migration, so it's also eligible for dynamic gas calculation.

Testing performed to validate your change

unit test

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.75%. Comparing base (3807a81) to head (12d0dd0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
precompiles/addr/addr.go 61.53% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
+ Coverage   61.67%   61.75%   +0.07%     
==========================================
  Files         264      264              
  Lines       23473    23478       +5     
==========================================
+ Hits        14477    14498      +21     
+ Misses       7988     7963      -25     
- Partials     1008     1017       +9     
Files with missing lines Coverage Δ
precompiles/addr/addr.go 63.80% <61.53%> (+8.10%) ⬆️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

@philipsu522 philipsu522 merged commit f324752 into main Nov 25, 2024
48 of 49 checks passed
@philipsu522 philipsu522 deleted the addr-dynamic-gas branch November 25, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants