Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] getLogs endpoint should check whether or not to include cosmos Txs based on namespace #1988

Merged
merged 9 commits into from
Dec 12, 2024
Merged

[Bug Fix] getLogs endpoint should check whether or not to include cosmos Txs based on namespace #1988

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e087480
Fix GetEthLogs: getEvmTxHashesFromBlock should exclude cosmos txs
yzang2019 Dec 11, 2024
67f773b
Fix unit test
yzang2019 Dec 12, 2024
83f8f06
Merge branch 'main' into yzang/fix-getEthLogs
yzang2019 Dec 12, 2024
7511127
Fix test failure and add a check for synthetic logs
yzang2019 Dec 12, 2024
4fe7711
Fix test
yzang2019 Dec 12, 2024
f9d2446
Fix log
yzang2019 Dec 12, 2024
1b983c9
Increase fee
yzang2019 Dec 12, 2024
ba5ad04
Add fee
yzang2019 Dec 12, 2024
58b0dc9
Test
yzang2019 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions evmrpc/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package evmrpc
import (
"context"
"crypto/ecdsa"
"crypto/sha256"
"encoding/hex"
"fmt"
"math/big"
Expand Down Expand Up @@ -216,7 +215,6 @@ func getEvmTxHashesFromBlock(block *coretypes.ResultBlock, txConfig client.TxCon
continue
}
if len(sdkTx.GetMsgs()) == 0 {
txHashes = append(txHashes, sha256.Sum256(tx))
continue
}
if evmTx, ok := sdkTx.GetMsgs()[0].(*types.MsgEVMTransaction); ok {
Expand All @@ -226,7 +224,6 @@ func getEvmTxHashesFromBlock(block *coretypes.ResultBlock, txConfig client.TxCon
ethtx, _ := evmTx.AsTransaction()
txHashes = append(txHashes, ethtx.Hash())
}
txHashes = append(txHashes, sha256.Sum256(tx))
}
return txHashes
}
Loading