Add new MinTxsInBlock consensus param

[codchen]

Describe your changes and provide context

Add a new param to specify the minimum number of transactions to take into a block (as long as there are so many in the mempool) regardless of the max gas for a block. Some things to note:

• a single transaction still cannot exceed the max gas by itself
• max bytes will still take precedence

Testing performed to validate your change

integrated with sei-chain and tested in local sei

[philipsu522]

coudl we add unit tests for when this value isn't 0?

[codchen]

added

[stevenlanders]

it might be good to permutate these situations:

• min txs reached / not reached
• min size reached / not reached
• min gas reached / not reached
• with combinations of configurations (has gas/size/txs config)
  (chat gpt should be able to help make a scenario-based test for that)

[philipsu522]

nit - "must be non-negative"

[codchen]

updated

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.27%. Comparing base (57e0107) to head (bea5c8f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/consensus/replay_stubs.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   58.10%   58.27%   +0.16%     
==========================================
  Files         249      249              
  Lines       34555    34559       +4     
==========================================
+ Hits        20079    20138      +59     
+ Misses      12877    12828      -49     
+ Partials     1599     1593       -6     

Files with missing lines	Coverage Δ
internal/mempool/mempool.go	73.58% <100.00%> (+0.16%)	⬆️
internal/mempool/types.go	0.00% <ø> (ø)
internal/state/execution.go	61.83% <100.00%> (ø)
internal/consensus/replay_stubs.go	47.36% <33.33%> (ø)

... and 17 files with indirect coverage changes

[stevenlanders]

this might need to be also or size threshold is exceeded. I suspect the incremented values totalSize, totalGas should only be incremented if the transaction is appended?

[stevenlanders]

here's kinda what i'm thinking:

txmp.priorityIndex.ForEachTx(func(wtx *WrappedTx) bool {
	size := types.ComputeProtoSizeForTxs([]types.Tx{wtx.tx})
	if len(txs) >= int(minTxsInBlock) {
		if thresholdExceeded(maxBytes, totalSize, size) {
			return false
		}
		if thresholdExceeded(maxGas, totalGas, wtx.gasWanted) {
			return false
		}
	}
	totalGas += wtx.gasWanted
	totalSize += size

	txs = append(txs, wtx.tx)
	return true
})

with helper:

func thresholdExceeded(threshold, totalSoFar, txValue int64) bool {
	return threshold > -1 && ((totalSoFar + txValue) > threshold)
}

[codchen]

I don't think we should exempt txs from exceeding size limit since a large size does mean we need to store more data on chain (i.e. it's not sizeWanted but always sizeUsed)

[stevenlanders]

it might be good to permutate these situations:

• min txs reached / not reached
• min size reached / not reached
• min gas reached / not reached
• with combinations of configurations (has gas/size/txs config)
  (chat gpt should be able to help make a scenario-based test for that)