Add timeout to create #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
requested review from
philipsu522,
yzang2019 and
udpatil
and removed request for
yzang2019
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+33
to
+36
| go func() { | ||
| checksum, err = w.WasmerEngine.Create(code) | ||
| done <- struct{}{} | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
philipsu522
approved these changes
Jan 3, 2024
yzang2019
reviewed
Jan 3, 2024
x/wasm/keeper/vm_wrapper.go
Outdated
|
|
||
| "github.com/CosmWasm/wasmd/x/wasm/types" | ||
| wasmvm "github.com/CosmWasm/wasmvm" | ||
| wasmvmtypes "github.com/CosmWasm/wasmvm/types" | ||
| ) | ||
|
|
||
| const CreateTimeout time.Duration = 5 * time.Second |
There was a problem hiding this comment.
5 seconds seems pretty low timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain inputs may cause vm.create to take an indefinite amount of time, effectively leaving the chain in a hanging state. This PR adds a 5-second timeout to
create. This is a bandaid fix. The real fix will be in CosmWasm's Jan release.Tested with local sei using:
seid tx wasm store ~/Downloads/exp.wasm --from admin --gas 35000000 --fees 30000000usei -y -b block