-
Notifications
You must be signed in to change notification settings - Fork 45
[CLNP-7474] feat: supprot-for-text-input-props #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…SendInput components
…pChannel (e.g. autoCorrect)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 11.26% 11.25% -0.01%
==========================================
Files 360 360
Lines 8680 8686 +6
Branches 2332 2472 +140
==========================================
Hits 978 978
+ Misses 7701 7632 -69
- Partials 1 76 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for controlling autoCorrect
functionality in GroupChannelInput and fixes an iOS-specific issue where text remained in the input field after sending messages when autoCorrect
was enabled.
- Adds
partialTextInputProps
prop to allow configuration of TextInput properties likeautoCorrect
- Implements iOS-specific fix for text clearing issue when
autoCorrect
is enabled - Threads the new prop through the component hierarchy from GroupChannel to input components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx | Passes partialTextInputProps to GroupChannelInput component |
packages/uikit-react-native/src/domain/groupChannel/types.ts | Adds TypeScript definitions for partialTextInputProps |
packages/uikit-react-native/src/components/ChannelInput/index.tsx | Defines the interface for partialTextInputProps with restricted TextInputProps |
packages/uikit-react-native/src/components/ChannelInput/SendInput.tsx | Implements iOS-specific text clearing fix and applies partialTextInputProps to TextInput |
packages/uikit-react-native/src/components/ChannelInput/EditInput.tsx | Applies partialTextInputProps to EditInput TextInput component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-7474](https://sendbird.atlassian.net/browse/CLNP-7474)
Description Of Changes
GroupChannelInput 에서 autoCorrect기능을 on/off 할수 있도록 추가하였습니다.
autoCorrect 가 true 일때 iOS 에서 메세지 전송이후, 텍스트가 남아있는 현상 수정하였습니다.
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_