Updating closure control server code and closure app as per new specification update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabollim-silabs
changed the base branch from
feature/closure_control_cluster_update_xml_with_latest_spec
to
master
sabollim-silabs
changed the base branch from
master
to
feature/closure_control_cluster_xml_generation
sabollim-silabs
changed the base branch from
feature/closure_control_cluster_xml_generation
to
feature/closure_control_cluster_zap_generation
sabollim-silabs
changed the base branch from
feature/closure_control_cluster_zap_generation
to
feature/closure_control_cluster_update_xml_with_latest_spec
jmartinez-silabs
approved these changes
Mar 25, 2025
src/app/clusters/closure-control-server/closure-control-server.h
Outdated
Show resolved
Hide resolved
examples/closure-app/closure-common/closure-control/include/ClosureControlDelegate.h
Outdated
Show resolved
Hide resolved
examples/closure-app/closure-common/closure-control/src/ClosureControlDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
…eControlDelegateImpl.cpp Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
…osureControlDelegate.h Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
sabollim-silabs
changed the title
sabollim-silabs
force-pushed
the
closure_control_server_code_with_latest_spec
branch
from
7cc15a5 to
4a09b57
Compare
sabollim-silabs
changed the base branch from
feature/closure_control_cluster_update_xml_with_latest_spec
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Built the app., flashed it on the device and able to commission using chiptool