Skip to content

Commit

Permalink
feat(chart): add extraVolumes + extraVolumeMounts
Browse files Browse the repository at this point in the history
Adds extraVolumes / extraVolumeMounts to the Helm chart. Allows to, for example, mount a custom CA to `/etc/ssl/certs/ca-certificates.crt`, to avoid having to use `insecure: true`.

Fixes #65.

Signed-off-by: Philipp Born <git@pborn.eu>
  • Loading branch information
tamcore committed Oct 24, 2023
1 parent 5c1a382 commit fd80570
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 1 deletion.
1 change: 1 addition & 0 deletions .conform.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ policies:
scopes:
- deps
- main
- chart
descriptionLength: 72
- type: license
spec:
Expand Down
2 changes: 1 addition & 1 deletion charts/proxmox-cloud-controller-manager/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ maintainers:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.7
version: 0.1.8

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 2 additions & 0 deletions charts/proxmox-cloud-controller-manager/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ helm upgrade -i --namespace=kube-system -f proxmox-ccm.yaml \
| nodeSelector | object | `{}` | Node labels for data pods assignment. ref: https://kubernetes.io/docs/user-guide/node-selection/ |
| tolerations | list | `[{"effect":"NoSchedule","key":"node-role.kubernetes.io/control-plane","operator":"Exists"},{"effect":"NoSchedule","key":"node.cloudprovider.kubernetes.io/uninitialized","operator":"Exists"}]` | Tolerations for data pods assignment. ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ |
| affinity | object | `{}` | Affinity for data pods assignment. ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity |
| extraVolumes | list | `[]` | Additional volumes for Pods |
| extraVolumeMounts | list | `[]` | Additional volume mounts for Pods |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.11.2](https://github.com/norwoodj/helm-docs/releases/v1.11.2)
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ spec:
- name: cloud-config
mountPath: /etc/proxmox
readOnly: true
{{- with .Values.extraVolumeMounts }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down Expand Up @@ -100,3 +103,6 @@ spec:
secretName: {{ include "proxmox-cloud-controller-manager.fullname" . }}
defaultMode: 416
{{- end }}
{{- with .Values.extraVolumes }}
{{- toYaml . | nindent 8 }}
{{- end }}
11 changes: 11 additions & 0 deletions charts/proxmox-cloud-controller-manager/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,14 @@ tolerations:
# -- Affinity for data pods assignment.
# ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity
affinity: {}

# -- Additional volumes for Pods
extraVolumes: []
# - name: ca
# secret:
# secretName: my-ca
# -- Additional volume mounts for Pods
extraVolumeMounts: []
# - mountPath: /etc/ssl/certs/ca-certificates.crt
# name: ca
# subPath: ca.crt

0 comments on commit fd80570

Please sign in to comment.