-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app directory migration #2825
app directory migration #2825
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
next.config.js
Outdated
? [ | ||
{ | ||
source: '/app-dir-testing/:path*', | ||
destination: '/app-dir-testing/de/:path*', // <- you can set the language of the frontend here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach here: Make language static. You can still easily change it to another language if you want to develop for it. This way, no middleware is needed (and this makes the mental model a lot easier)
This attempt got quite far, but due to some remaining bugs and challenges (see description), we will postpone this for some more months. |
This PR will migrate all of
pages
intoapp
. It's faster to do it in one go and many things are already working nicely.list of current to-dos:
app
directory hashicorp/nextjs-bundle-analysis#42cache
preview: https://frontend-git-2823-another-attempt-at-adopting-app-234955-serlo.vercel.app/1553