Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app directory migration #2825

Closed

Conversation

Entkenntnis
Copy link
Member

@Entkenntnis Entkenntnis commented Aug 30, 2023

This PR will migrate all of pages into app. It's faster to do it in one go and many things are already working nicely.

list of current to-dos:

preview: https://frontend-git-2823-another-attempt-at-adopting-app-234955-serlo.vercel.app/1553

@Entkenntnis Entkenntnis linked an issue Aug 30, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Aug 31, 2023 9:46am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 75.54 KB (🟢 -22 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/_error 230 B (🟢 -1 B) 75.76 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

next.config.js Outdated
? [
{
source: '/app-dir-testing/:path*',
destination: '/app-dir-testing/de/:path*', // <- you can set the language of the frontend here
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elbotho

Approach here: Make language static. You can still easily change it to another language if you want to develop for it. This way, no middleware is needed (and this makes the mental model a lot easier)

@Entkenntnis Entkenntnis changed the title app directory test app directory migration Aug 30, 2023
@Entkenntnis
Copy link
Member Author

This attempt got quite far, but due to some remaining bugs and challenges (see description), we will postpone this for some more months.

@Entkenntnis Entkenntnis closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

another attempt at adopting app directory
1 participant