fix: use serviceDir while injecting requirements to ensure compatibility with v4 Compose #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czubocha
force-pushed
the
fix-v4-compose
branch
2 times, most recently
from
a3136a1 to
c618c7d
Compare
czubocha
force-pushed
the
fix-v4-compose
branch
from
c618c7d to
dfc5638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v4 Compose, unlike in v3 Compose, separate processes are not spawned for individual services. As a result, the current working directory always remains where serverless-compose.yml is located. Therefore, we need to ensure that the correct absolute path is used instead of a path relative to the service directory. To create an absolute path we can use
this.serverless.serviceDir.Adressess serverless/serverless#12982