-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve entry point lookup function documentation #6451
Improve entry point lookup function documentation #6451
Conversation
d25be96
to
2165c51
Compare
2165c51
to
46ee809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but someone else should approve
There is no bug to be fixed here. If the source code did not specify [shader()] attribute, the host side should call |
@csyonghe IIUC the user guide just states that [shader(...)] should not be needed: #4760 (comment). I don't find any mentions of I ran into this because several tests don't specify [shader(...)], and those fail to look up entry points when I migrate away from the deprecated build request API. |
It is documented here: https://shader-slang.org/docs/compilation-api/#query-entry-points |
At least I see this doc comment for
The I will change the patch accordingly. |
…shader(...)] attribute
…nts without [shader(...)] attributes
46ee809
to
a76bfdf
Compare
@csyonghe I added a mention in the user guide and slang.h as well. I think it's worth mentioning there since it would have saved me some time... |
looks good! needs a formatting fix. |
/format |
🌈 Formatted, please merge the changes from this PR |
…ookup-bug Format code for PR shader-slang#6451
Add a unit test for the case where the code does not specify entry points, but they are instead specified via the APIMake the entry point lookup logic check the information in the options#6452
See also issue #4760.