Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dependency on slang-glsl-module-generated.h #6591

Open
lunarpapillo opened this issue Mar 12, 2025 · 1 comment
Open

missing dependency on slang-glsl-module-generated.h #6591

lunarpapillo opened this issue Mar 12, 2025 · 1 comment
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang

Comments

@lunarpapillo
Copy link

lunarpapillo commented Mar 12, 2025

While attempting to build for the Vulkan SDK, among the other sporadic cross-platform build failures we've been seeing is:

C:\j\msdk1\build\slang\repo\source\slang-glsl-module\slang-embedded-glsl-module.cpp(6,10): fatal error C1083: Cannot open include file: 'slang-glsl-module-generated.h': No such file or directory [C:\j\msdk1\build\slang\repo\dbuild\source\slang-glsl-module\slang-glsl-module.vcxproj]

This appears only infrequently in our builds (other issues, like #6580 , are much more frequent), but suggests that there's a missing dependency causing a race condition between creating slang-glsl-module-generated.h and its consumers.

@bmillsNV bmillsNV added this to the Q1 2025 (Winter) milestone Mar 13, 2025
@bmillsNV bmillsNV added goal:client support Feature or fix needed for a current slang user. goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang and removed goal:client support Feature or fix needed for a current slang user. labels Mar 13, 2025
@expipiplus1
Copy link
Collaborator

This is so weird,

the only place this header is used is in source/slang-glsl-module/slang-embedded-glsl-module.cpp which is used in source/slang-glsl-module/CMakeLists.txt to generate the slang-glsl-module target. This target has an explicit dependency on the generate_core_module_headers custom target which depends on that header.

Are you able to reproduce this with a single threaded build or with a different cmake generator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Development

No branches or pull requests

3 participants