Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an explicit dependency for generated headers instead of source file dependency #6594

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

expipiplus1
Copy link
Collaborator

From the CMake Docs

Do not list the output in more than one independent target that may build in parallel or the instances of the rule may conflict. Instead, use the add_custom_target() command to drive the command and make the other targets depend on that one. See the Example: Generating Files for Multiple Targets below.

Hopefully closes #6580 and #6591

…le dependency

From the CMake Docs

> Do not list the output in more than one independent target that may build in parallel or the instances of the rule may conflict. Instead, use the add_custom_target() command to drive the command and make the other targets depend on that one. See the Example: Generating Files for Multiple Targets below.
@expipiplus1 expipiplus1 added the pr: non-breaking PRs without breaking changes label Mar 13, 2025
@expipiplus1 expipiplus1 requested a review from a team as a code owner March 13, 2025 05:39
Copy link
Contributor

@gtong-nv gtong-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally. Running the build 10 times with MSBuild and they all pass and produce headers files with all hex numbers.

@csyonghe csyonghe merged commit 3431640 into shader-slang:master Mar 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sporadic corruption in slang-core-module-generated.h
3 participants