Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an explicit dependency for generated headers instead of source file dependency #6594

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Use an explicit dependency for generated headers instead of source file dependency #6594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e4da6e
Simplify text writing for core module headers
expipiplus1 Mar 13, 2025
05f5632
Use an explicit dependency for generated headers instead of source fi…
expipiplus1 Mar 13, 2025
a26b6f4
Merge branch 'master' into push-wrqrnwmqxtzm
csyonghe Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/slang-core-module/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ set(core_module_common_args
slang_add_target(
${core_module_common_args}
TARGET_NAME slang-embedded-core-module
EXPLICIT_SOURCE ${core_module_generated_header}
REQUIRES generate_core_module_headers
EXTRA_COMPILE_DEFINITIONS_PRIVATE SLANG_EMBED_CORE_MODULE
INCLUDE_DIRECTORIES_PRIVATE ${core_module_generated_header_dir}
)
Expand Down
2 changes: 1 addition & 1 deletion source/slang/slang-options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2260,7 +2260,7 @@ SlangResult OptionsParser::_parse(int argc, char const* const* argv)
16,
&writer));

File::writeAllText(fileName.value, builder);
File::writeNativeText(fileName.value, builder.getBuffer(), builder.getLength());
break;
}
case OptionKind::DumpIrIds:
Expand Down
Loading