DO NOT REVIEW YET: Proper fix for COMPARE_HLSL_RENDER and WGPU API #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D3D12Core.dll had been copied to a wrong directory and slang has been using D3D12Core.dll from the system directory, C:\windows\system32. D3D12Core.dll has to be copied from external/slang-binaries/bin/windows-x64 to build/Release/bin/D3D12 not to build/Release/bin. The same is true for the debug build and it had to be copied to build/Debug/bin/D3D12 not build/Debug/bin. It hasn't been a problem for Release build, because the debug-layer is not enabled for Release build and it didn't cause the version mismatching problem with D3D12SDKLayers.dll. The Release build was loaded from either build/Release/bin or from C:\windows\system32, and it didn't matter which one was used. The Debug build, however, got into a problem where D3D12Core.dll was loaded from the system directory whereas D3D12SDKLayers.dll was loaded from build/Debug/bin and it failed to load D3D12.dll entirely. This caused D3D12 to be "Not supported" for "Windows/Debug" configuration. Note that our CI explicitly excludes DX12 tests for the "Windows/Debug" configuration with a command-line argument "-api all-dx12", and DX12 tests were going to be ignored anyway. The actual problem was observed when WGPU is implemented. WGPU started printing explicit errors for the load failure of D3D12.dll. See more detailed explanation: https://devblogs.microsoft.com/directx/gettingstarted-dx12agility/#d3d12sdkpath-should-not-be-the-same-directory-as-the-application-exe Closes shader-slang#5305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5276
The issue turned out to be related to the use of
COMPARE_HLSL_RENDERkeyword in the file,tests/bugs/texture2d-gather.hlsl.The fact that the file has an extension, ".hlsl", was unrelated to the issue.
The document describes what
COMPARE_HLSL_RENDERdoes as following,Basically, it compiles the given shader with DXC compiler and generate an output image.
And then it compiles with each and every render API and generate an output image and compare it to the output from DXC.
The problem is on how the input arguments are generated when rendering for metal and wgpu.
The command-line argument for rendering with DXC is, as an example,
And the command-line argument for rendering with WGPU API is,
The first set of arguments conflict in a way that "-wgpu" instructs to use Tint as the renderer at the same time, it tells to use DXC compile with the next argument, "-hlsl". In this case, "-wgpu" should be ignored.
The second set is kind of O.K, because "-slang" and "-wgpu" don't conflict. "-slang" instructs to treat the input as slang shader and "-wgpu" instructs to use WGPU as the output render API.