Fix two specialization bugs #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first bug was introduced in b2ca2d5 and ran some code at scope exit that dereferenced a nullptr context. The second bug was introduced in bea1394 and would cause the wrong mangled name to be used during specialization. This closes shader-slang#5516.
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#5540
csyonghe
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first bug was introduced in b2ca2d5 and ran some code at scope exit that dereferenced a nullptr context.
The second bug was introduced in bea1394 and would cause the wrong mangled name to be used during specialization.
This closes #5516.