-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wgsl: Fix field semantics even if input struct doesn't need flattening #5642
wgsl: Fix field semantics even if input struct doesn't need flattening #5642
Conversation
Helps to address issue shader-slang#5633.
3cc1f53
to
568072b
Compare
This verifies part of issue shader-slang#5633.
568072b
to
9d38a18
Compare
Falcor tests failed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel uncomfortable with this change.
The code is copied exactly from slang-ir-metal-legalize.cpp
And with this PR, WGPU side works but Metal side is failing.
I suggest to investigate why Metal is failing and fix it properly before merging this change.
I feel like metal needs the same treatment. |
Yes, that must be it. |
|
Here is a PR |
This fixes an issue where location indices of stage inputs were repeated
#5633