WGPU: Add new test and explanation for disabled test #5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Dec 3, 2024
…ions Format code for PR shader-slang#5731
jkwak-work
previously approved these changes
Dec 3, 2024
| @@ -1,7 +1,7 @@ | |||
| //TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj -output-using-type | |||
| //TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -output-using-type | |||
| //TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl -output-using-type | |||
| // Slang-RHI/WGPU: Invalid bind group layout entry used #5612 | |||
| // Not supported in WGSL: read-write storage texture with "rg16f" format | |||
There was a problem hiding this comment.
If the format is only problem for WGSL, can we change the format to one of formats WGSL supports?
Or maybe we can copy this test with a different format.
There was a problem hiding this comment.
Yeah I can give it a shot.
There are some Slang-RHI issues related to storage textures I need to fix first though -- it currently doesn't create the bind group layout entry properly. I think I should set the access field to read-write, but I'm not quite sure how I should then get the required format information. I think I'll have to check in with Simon.
aleino-nv
force-pushed
the
aleino/wgpu-explanations
branch
from
3060acb to
c69b622
Compare
csyonghe
previously approved these changes
Dec 3, 2024
|
Needs another re-format. |
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
…ions Format code for PR shader-slang#5731
jkwak-work
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments on #5612 for more details.
This closes #5612.