Implement AnyValue marshalling for 8-bit integers #6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
previously approved these changes
Jan 10, 2025
|
Whoops, missed that _getAnyValueSizeRaw actually tracks offset, not exactly size of the individual parameter. Hopefully that's what caused that Windows DX12 test to fail. |
csyonghe
previously approved these changes
Jan 10, 2025
Because it doesn't support 8-bit values anyway.
|
I took out that DXIL test. I figured out that it's not possible to compile code containing uint8_t there, this is in the same boat as #3591. Which is why that test fails too. This feature has been backlogged for a future shader model on Microsoft's side, so there's not much we can do for now. |
|
Heh, formatting issue from master. Since it's now fixed there, I'll just click that Update branch button and let it sort itself out. |
csyonghe
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this closes #4817?
Based on the discussion in that issue, I implemented this using the now-existing BitfieldInsert & BitfieldExtract instead of the shift and mask approach (which is currently used for 16-bit types) and added a test.
I only realized that there was already an issue about this after having already implemented the shift + mask version, and I have to say that this BitfieldInsert & Extract approach is much cleaner to implement as well.