test-server should use d3d12core.dll from bin directory #6095
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit explicitly specifies where the d3d12core.dll is located. Currently slang-test.exe uses build/XX/bin/D3D12/d3d12core.dll whereas test-server.exe uses one from c:/windows/system32/d3d12core.dll
|
Investigating why two tests are failing, |
This was referenced Jan 16, 2025
|
The failing tests revealed a bug in Slang side. |
|
I think it makes sense to mark the failing tests as expected to fail and track it in the issue 6104. |
|
Currently this PR is failing on a test, |
csyonghe
approved these changes
Jan 18, 2025
jkwak-work
deleted the
fix/test_server_should_use_a_custom_d3d12core_dll
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit explicitly specifies where the d3d12core.dll is located.
Currently slang-test.exe uses build/XX/bin/D3D12/d3d12core.dll whereas test-server.exe uses one from c:/windows/system32/d3d12core.dll