Fix WGSL entry point parameter location attributes #6116
Merged
+21
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
approved these changes
Jan 17, 2025
csyonghe
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5933.
For WGSL entry points, location attributes are only applied to struct parameters. This is a side-effect of reusing code from Metal, where the same behavior applies, but Metal legalization performs packing of all parameters to a common struct first hence all parameters are appropriately assigned attributes, while WGSL does not perform packing and some parameters are not assigned attributes.
This change applies Metal's hoisting and packing logic to WGSL's entry point legalization.