Disallow only resources in constant buffers in parameterblocks on metal #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
reviewed
Feb 12, 2025
There was a problem hiding this comment.
We need a test to confirm that if you get the element type layout for parameterBlock.cbuffer, the type layout is produced from constant buffer rules (e.g. oridinary data fields has uniform byte offsets) instead of from metal argument buffer rules (where orindary data fields does not have uniform byte offsets and instead have argument buffer ids).
expipiplus1
force-pushed
the
push-skqpzxutnxos
branch
from
d2f85bd to
f980f75
Compare
|
ok, I added a test for a cbuffer and non cbuffer wrapped struct, verifying the offsets. |
csyonghe
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loosens the check on constant buffers in parameter blocks in metal
Disallow only resources in constant buffers in parameterblocks on metal
closes #6200