-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WaveGetLane* support for Metal and WGSL #6371
Merged
csyonghe
merged 26 commits into
shader-slang:master
from
fairywreath:wgsl-global-param-builtin
Feb 28, 2025
+216
−113
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
dd7e4f9
support WaveGetLane* for WGSL and Metal
fairywreath 07bd6b7
update test and glsl support
fairywreath 3f334df
address review comments and fix metal test
fairywreath fd4d4e3
add missing pragma guard
fairywreath 87410a9
Merge branch 'master' into wgsl-global-param-builtin
fairywreath f2b97e9
update test
fairywreath 8221661
Merge branch 'master' into wgsl-global-param-builtin
fairywreath 260cccd
Revert "update test"
fairywreath 70e3eb1
update failing glsl metal test and added new test
fairywreath b670683
Merge branch 'master' into wgsl-global-param-builtin
fairywreath 51a565a
make hlsl and glsl outputs similar
fairywreath 1db6f43
update test
fairywreath 2824396
Merge branch 'master' into wgsl-global-param-builtin
fairywreath 1c42aa1
disable tests for Metal and cleanup
fairywreath 1fcc307
Merge branch 'master' into wgsl-global-param-builtin
fairywreath 94eadbd
comment fix
fairywreath 96a2e7b
add expected failures
fairywreath 397865f
Merge branch 'master' into wgsl-global-param-builtin
fairywreath 4dc0742
Merge branch 'master' into wgsl-global-param-builtin
fairywreath a8088ea
correct expected failures list
fairywreath bf11684
Merge branch 'master' into wgsl-global-param-builtin
fairywreath bb606e3
remove expected failure
fairywreath 51256fa
Merge branch 'master' into wgsl-global-param-builtin
fairywreath 9d6dd3f
add tests to expected failure
fairywreath a881dbe
Merge branch 'master' into wgsl-global-param-builtin
csyonghe 0ae2841
Merge branch 'master' into wgsl-global-param-builtin
csyonghe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables-2.slang
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of disable test here, let’s run the test, but add the test name to expected-failure.txt so we can always use that file to track tests that we still need to work on.